linux-kernel - Re: [PATCH -next] drm/hisilicon: Remove redundant dev_err call in ade_dts_parse()

Open Source and information security mailing list archives

Date:	Mon, 18 Jul 2016 09:22:09 +0800
From:	Xinliang Liu <xinliang.liu@...aro.org>
To:	weiyj_lk@....com
Cc:	Xinliang Liu <z.liuxinliang@...ilicon.com>,
	Xinwei Kong <kong.kongxinwei@...ilicon.com>,
	Chen Feng <puck.chen@...ilicon.com>,
	David Airlie <airlied@...ux.ie>,
	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH -next] drm/hisilicon: Remove redundant dev_err call in ade_dts_parse()

Hi, thanks. This patch had already applied to drm-hisilicon-next.

On 13 July 2016 at 20:44,  <weiyj_lk@....com> wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
>  drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> index 805f432..3aea3bb 100644
> --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> @@ -944,10 +944,8 @@ static int ade_dts_parse(struct platform_device *pdev, struct ade_hw_ctx *ctx)
>
>         res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>         ctx->base = devm_ioremap_resource(dev, res);
> -       if (IS_ERR(ctx->base)) {
> -               DRM_ERROR("failed to remap ade io base\n");
> +       if (IS_ERR(ctx->base))
>                 return  PTR_ERR(ctx->base);
> -       }
>
>         ctx->reset = devm_reset_control_get(dev, NULL);
>         if (IS_ERR(ctx->reset))
>
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives