linux-kernel - Re: [PATCH -next] drm/virtio: Fix non static symbol warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 19 Jul 2016 15:45:02 -0400
From:	Sean Paul <seanpaul@...gle.com>
To:	Wei Yongjun <weiyj_lk@....com>
Cc:	David Airlie <airlied@...ux.ie>, Gerd Hoffmann <kraxel@...hat.com>,
	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	dri-devel <dri-devel@...ts.freedesktop.org>,
	virtualization@...ts.linux-foundation.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] drm/virtio: Fix non static symbol warning

On Tue, Jul 19, 2016 at 8:45 AM, Wei Yongjun <weiyj_lk@....com> wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>
> Fixes the following sparse warning:
>
> drivers/gpu/drm/virtio/virtgpu_display.c:349:37: warning:
>   symbol 'virtio_mode_config_helpers' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>

Applied to drm-misc

> ---
>  drivers/gpu/drm/virtio/virtgpu_display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c
> index fdfc711..4e192aa 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_display.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_display.c
> @@ -346,7 +346,7 @@ static void vgdev_atomic_commit_tail(struct drm_atomic_state *state)
>         drm_atomic_helper_cleanup_planes(dev, state);
>  }
>
> -struct drm_mode_config_helper_funcs virtio_mode_config_helpers = {
> +static struct drm_mode_config_helper_funcs virtio_mode_config_helpers = {
>         .atomic_commit_tail = vgdev_atomic_commit_tail,
>  };
>
>