linux-kernel - Re: [RFC][PATCH 6/7] ASoC: hisilicon: Add hi6210 i2s audio driver for hdmi audio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 20 Jul 2016 01:21:18 +0100
From:	Mark Brown <broonie@...nel.org>
To:	John Stultz <john.stultz@...aro.org>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Andy Green <andy.green@...aro.org>,
	Zhangfei Gao <zhangfei.gao@...aro.org>,
	Jingoo Han <jg1.han@...sung.com>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Vinod Koul <vinod.koul@...el.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>, Wei Xu <xuwei5@...ilicon.com>,
	Rob Herring <robh+dt@...nel.org>,
	Andy Green <andy@...mcat.com>,
	Dave Long <dave.long@...aro.org>,
	Guodong Xu <guodong.xu@...aro.org>
Subject: Re: [RFC][PATCH 6/7] ASoC: hisilicon: Add hi6210 i2s audio driver
 for hdmi audio

On Tue, Jul 19, 2016 at 02:59:31PM -0700, John Stultz wrote:

> Then the probe/remove logic to register the codec, and connected it up
> with the simple card driver.

> Though it seems kind of silly to have a whole driver (and devicetree
> entry for the probe hook) just to fill and install the above
> structure. Is there a simpler way to specify that via a DT node
> instead?

Well, if you can use simple-card why not just use simple-card?

> >> +static const struct of_device_id hi6210_i2s_dt_ids[] = {
> >> +     { .compatible = "hisilicon,hi6210-i2s" },
> >> +     { /* sentinel */ }
> >> +};

> > The code makes this look like it's not just an I2S controller.

> I'm not sure I follow this? The dt ids make it seem like this driver
> is not an i2s controller?

No.  The *code* makes this look like it's not an I2S controller.  It
looks like it's a driver for a DSP/mixing block which may have an
integrated I2S controller, I pointed out things like some of the routing
control.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)