linux-kernel - Re: [PATCH] Staging: ks7010: michael_mic: fixed macros coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 Jul 2016 18:02:21 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Bing Sun <sunbing@...flag-linux.com>
Cc:	gregkh@...uxfoundation.org, wsa+renesas@...g-engineering.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	sunbing.linux@...il.com
Subject: Re: [PATCH] Staging: ks7010: michael_mic: fixed macros coding style
 issue

On Tue, Jul 19, 2016 at 09:51:06AM +0800, Bing Sun wrote:
> Fixed coding style issue:
> Enclose multiple statements macros definition in a do while loop.
> Use one space around binary operators.
> 
> Signed-off-by: Bing Sun <sunbing@...flag-linux.com>

Looks good for what it is. One comment below. I will test this tomorrow.

> ---
>  drivers/staging/ks7010/michael_mic.c | 20 +++++++++++++-------
>  1 file changed, 13 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/ks7010/michael_mic.c b/drivers/staging/ks7010/michael_mic.c
> index e14c109..d332678 100644
> --- a/drivers/staging/ks7010/michael_mic.c
> +++ b/drivers/staging/ks7010/michael_mic.c
> @@ -20,15 +20,21 @@
>  #define getUInt32( A, B ) 	(uint32_t)(A[B+0] << 0) + (A[B+1] << 8) + (A[B+2] << 16) + (A[B+3] << 24)
>  
>  // Convert from UInt32 to Byte[] in a portable way
> -#define putUInt32( A, B, C ) 	A[B+0] = (uint8_t) (C & 0xff);		\
> -				A[B+1] = (uint8_t) ((C>>8) & 0xff);	\
> -				A[B+2] = (uint8_t) ((C>>16) & 0xff);	\
> -				A[B+3] = (uint8_t) ((C>>24) & 0xff)
> +#define putUInt32(A, B, C)					\
> +do {								\
> +	A[B + 0] = (uint8_t)(C & 0xff);				\
> +	A[B + 1] = (uint8_t)((C >> 8) & 0xff);			\
> +	A[B + 2] = (uint8_t)((C >> 16) & 0xff);			\
> +	A[B + 3] = (uint8_t)((C >> 24) & 0xff);			\
> +} while (0)

We surely have helper functions for this in the kernel?

>  
>  // Reset the state to the empty message.
> -#define MichaelClear( A ) 	A->L = A->K0; \
> -				A->R = A->K1; \
> -				A->nBytesInM = 0;
> +#define MichaelClear(A)			\
> +do {					\
> +	A->L = A->K0;			\
> +	A->R = A->K1;			\
> +	A->nBytesInM = 0;		\
> +} while (0)
>  
>  static
>  void MichaelInitializeFunction(struct michel_mic_t *Mic, uint8_t * key)
> -- 
> 2.1.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)