linux-kernel - Re: [PATCH] GPU-DRM-sun4i: Delete an unnecessary check before drm_fbdev_cma_hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 Jul 2016 19:47:42 +0200
From:	Daniel Vetter <daniel@...ll.ch>
To:	SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:	dri-devel@...ts.freedesktop.org,
	linux-arm-kernel@...ts.infradead.org, Chen-Yu Tsai <wens@...e.org>,
	Daniel Vetter <daniel@...ll.ch>,
	David Airlie <airlied@...ux.ie>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] GPU-DRM-sun4i: Delete an unnecessary check before
 drm_fbdev_cma_hotplug_event()

On Wed, Jul 20, 2016 at 06:40:49PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Wed, 20 Jul 2016 18:32:34 +0200
> 
> The drm_fbdev_cma_hotplug_event() function tests whether its argument
> is NULL and then returns immediately.
> Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Applied to drm-misc, thanks.
-Daniel

> ---
>  drivers/gpu/drm/sun4i/sun4i_framebuffer.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/sun4i/sun4i_framebuffer.c b/drivers/gpu/drm/sun4i/sun4i_framebuffer.c
> index a0b30c2..70688fe 100644
> --- a/drivers/gpu/drm/sun4i/sun4i_framebuffer.c
> +++ b/drivers/gpu/drm/sun4i/sun4i_framebuffer.c
> @@ -20,8 +20,7 @@ static void sun4i_de_output_poll_changed(struct drm_device *drm)
>  {
>  	struct sun4i_drv *drv = drm->dev_private;
>  
> -	if (drv->fbdev)
> -		drm_fbdev_cma_hotplug_event(drv->fbdev);
> +	drm_fbdev_cma_hotplug_event(drv->fbdev);
>  }
>  
>  static const struct drm_mode_config_funcs sun4i_de_mode_config_funcs = {
> -- 
> 2.9.2
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch