linux-kernel - Re: [PATCH v2] fuse: fuse_flush must check mapping->flags for errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 21 Jul 2016 12:28:41 +0200
From:	Miklos Szeredi <miklos@...redi.hu>
To:	Maxim Patlasov <mpatlasov@...tuozzo.com>
Cc:	linux-fsdevel@...r.kernel.org,
	fuse-devel <fuse-devel@...ts.sourceforge.net>, devel@...nvz.org,
	linux-kernel@...r.kernel.org, kuznet@...tuozzo.com
Subject: Re: [PATCH v2] fuse: fuse_flush must check mapping->flags for errors

On Wed, Jul 20, 2016 at 3:12 AM, Maxim Patlasov <mpatlasov@...tuozzo.com> wrote:
> fuse_flush() calls write_inode_now() that triggers writeback, but actual
> writeback will happen later, on fuse_sync_writes(). If an error happens,
> fuse_writepage_end() will set error bit in mapping->flags. So, we have to
> check mapping->flags after fuse_sync_writes().
>
> Changed in v2:
>  - fixed silly type: check must be *after* fuse_sync_writes()

I applied both with a cleanup patch at the end to use the
filemap_check_errors() helper, which does exactly this.

Thanks,
Miklos