linux-kernel - Re: [PATCH] Revert "pinctrl: amd: make it explicitly non-modular"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 22 Jul 2016 17:27:09 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jean Delvare <jdelvare@...e.de>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH] Revert "pinctrl: amd: make it explicitly non-modular"

On Tue, Jul 19, 2016 at 2:30 AM, Paul Gortmaker
<paul.gortmaker@...driver.com> wrote:

> This reverts commit b8c2b10a9bc0272a20e096852f8fbbf361749dda.
>
> This patch was in my queue at the same time that a conversion of
> the same driver from bool --> tristate was pending and merged.
>
> That is commit 337ea0fb1535 ("pinctrl: Turn AMD support to tristate")
>
> Normally the conflict would show up in the build coverage I do,
> however in this case an avoidable instance of linux/module.h in
> linux/gpio/driver.h (!) causes the build failure to be masked and
> instead the tristate gets built-in even for selected "=m".
>
> In working on removing module.h from driver.h this issue was then
> revealed (along with other implicit module.h assumptions in gpio,
> and mfd -- which will be fixed separately.)
>
> Cc: Jean Delvare <jdelvare@...e.de>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: linux-gpio@...r.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Patch applied with Jean's ACK.

Yours,
Linus Walleij