linux-kernel - Re: RFC: silencing kvm unimplemented msr spew.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 Jul 2016 12:20:27 -0400 (EDT)
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Bandan Das <bsd@...hat.com>
Cc:	Dave Jones <dsj@...com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Radim Krčmář <rkrcmar@...hat.com>,
	kvm@...r.kernel.org
Subject: Re: RFC: silencing kvm unimplemented msr spew.


> >> Paolo, would you prefer this, or the other approach you already ack'd ?
> >
> > I think I prefer the other, because vcpu_debug is not ratelimited.
> > If the guest can trigger a printk it should always be ratelimited.
> 
> Agree with rate limiting, but making this the default for everything doesn't
> sound right IMO, especially for ignore_msrs=1. vcpu_unimpl is already rate
> limited.

The problem is that your patch removes rate limiting whenever it now
uses vcpu_debug.

Paolo