linux-kernel - Re: [PATCH 1/7] k3dma: Fix hisi burst clipping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 24 Jul 2016 12:55:09 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	John Stultz <john.stultz@...aro.org>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Andy Green <andy.green@...aro.org>,
	Zhangfei Gao <zhangfei.gao@...aro.org>,
	Jingoo Han <jg1.han@...sung.com>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Mark Brown <broonie@...nel.org>, Andy Green <andy@...mcat.com>
Subject: Re: [PATCH 1/7] k3dma: Fix hisi burst clipping

On Wed, Jul 20, 2016 at 08:53:03PM -0700, John Stultz wrote:
> From: Andy Green <andy.green@...aro.org>
> 
> Max burst len is a 4-bit field, but at the moment it's clipped with
> a 5-bit constant... reduce it to that which can be expressed

Maybe we should GENMASK() etc to avoid these errors..

>  	if ((maxburst == 0) || (maxburst > 16))
> -		val = 16;
> +		val = 15;

-- 
~Vinod