linux-kernel - xfs_icache.c:1298]: (style) Redundant condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Jul 2016 16:13:28 +0100
From:	David Binderman <linuxdev.baldrick@...il.com>
To:	david@...morbit.com, xfs@....sgi.com,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	dcb314@...mail.com
Subject: xfs_icache.c:1298]: (style) Redundant condition

Hello there,

linux-4.7/fs/xfs/xfs_icache.c:1298]: (style) Redundant condition:
eofb. '!eofb || (eofb && eofb.eof_scan_owner!=0)' is equivalent to
'!eofb || eofb.eof_scan_owner!=0'

Source code is

   ASSERT(!eofb || (eofb && eofb->eof_scan_owner != 0));

Maybe better code

   ASSERT(!eofb || (eofb->eof_scan_owner != 0));

Regards

David Binderman