linux-kernel - Re: [PATCH 1/1 linux-next] kbuild: add make force=1 for testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Jul 2016 17:05:55 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Fabian Frederick <fabf@...net.be>
Cc:	Robert Jarzmik <robert.jarzmik@...e.fr>,
	Michal Marek <mmarek@...e.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1 linux-next] kbuild: add make force=1 for testing

On Sun, 24 Jul 2016 15:28:18 +0200 Fabian Frederick <fabf@...net.be> wrote:

> Commit 51193b76bfff
> ("kbuild: forbid kernel directory to contain spaces and colons")
> 
> makes it impossible to build kernel on default SD labels like
> "SD Card" for instance.
> 
> Makefile:133: *** main directory cannot contain spaces nor colons.  Stop.
> 
> User could rename directories but volume name is not always writable.
> 
> This patch adds ability to do make force=1 for people
> not interested in modules_install in this case but only testing.
> 
> (Note that other options could go under ifndef force)

That's a bit of a hack on a hack.

51193b76bfff said:

:    When the kernel path contains a space or a colon somewhere in the path
:    name, the modules_install target doesn't work anymore, as the path names
:    are not enclosed in double quotes. It is also supposed that and O= build
:    will suffer from the same weakness as modules_install.
:    
:    Instead of checking and improving kbuild to resist to directories
:    including these characters, error out early to prevent any build if the
:    kernel's main directory contains a space.

What's involved in fixing this properly?  Make the whole kbuild
system operate correctly when there are spaces/colons in the
pathname?