linux-kernel - Re: [PATCH v1] x86, kasan, ftrace: Put APIC interrupt handlers into .irqentry.text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Jul 2016 08:45:17 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	kbuild test robot <lkp@...el.com>
Cc:	Alexander Potapenko <glider@...gle.com>, kbuild-all@...org,
	dvyukov@...gle.com, kcc@...gle.com, aryabinin@...tuozzo.com,
	x86@...nel.org, mingo@...hat.com, kasan-dev@...glegroups.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] x86, kasan, ftrace: Put APIC interrupt handlers into
 .irqentry.text

On Fri, 15 Jul 2016 17:19:46 +0800
kbuild test robot <lkp@...el.com> wrote:

> Hi,
> 
> [auto build test WARNING on tip/x86/core]
> [also build test WARNING on v4.7-rc7 next-20160714]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Alexander-Potapenko/x86-kasan-ftrace-Put-APIC-interrupt-handlers-into-irqentry-text/20160715-152601
> config: x86_64-acpi-redef (attached as .config)
> compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
> 
> All warnings (new ones prefixed by >>):
> 
> >> arch/x86/entry/entry_64.S:674:15: warning: extra tokens at end of #ifdef directive  
>     #ifdef defined(CONFIG_FUNCTION_GRAPH_TRACER) || defined(CONFIG_KASAN)

Alexander,

Can you send a v2 with this fixed?

-- Steve

>                   ^
> 
> vim +674 arch/x86/entry/entry_64.S
> 
>    658	END(\sym)
>    659	.endm
>    660	
>    661	#ifdef CONFIG_TRACING
>    662	#define trace(sym) trace_##sym
>    663	#define smp_trace(sym) smp_trace_##sym
>    664	
>    665	.macro trace_apicinterrupt num sym
>    666	apicinterrupt3 \num trace(\sym) smp_trace(\sym)
>    667	.endm
>    668	#else
>    669	.macro trace_apicinterrupt num sym do_sym
>    670	.endm
>    671	#endif
>    672	
>    673	/* Make sure APIC interrupt handlers end up in the irqentry section. */
>  > 674	#ifdef defined(CONFIG_FUNCTION_GRAPH_TRACER) || defined(CONFIG_KASAN)  
>    675	#define PUSH_SECTION_IRQENTRY	.pushsection .irqentry.text, "ax"
>    676	#define POP_SECTION_IRQENTRY	.popsection
>    677	#else
>    678	#define PUSH_SECTION_IRQENTRY
>    679	#define POP_SECTION_IRQENTRY
>    680	#endif
>    681	
>    682	.macro apicinterrupt num sym do_sym
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation