linux-kernel - Re: [PATCH 1/1] Drivers: infiniband: hw: vmbus-nd: NetworkDirect driver for Linux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Jul 2016 07:25:21 +0300
From:	Leon Romanovsky <leon@...nel.org>
To:	kys@...rosoft.com
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	devel@...uxdriverproject.org, linux-rdma@...r.kernel.org,
	yishaih@...lanox.com, sean.hefty@...el.com, dledford@...hat.com,
	olaf@...fle.de, apw@...onical.com, vkuznets@...hat.com,
	jasowang@...hat.com, leann.ogasawara@...onical.com,
	longli@...rosoft.com
Subject: Re: [PATCH 1/1] Drivers: infiniband: hw: vmbus-nd: NetworkDirect
 driver for Linux

On Tue, Jul 26, 2016 at 07:05:37PM -0700, kys@...hange.microsoft.com wrote:
> From: K. Y. Srinivasan <kys@...rosoft.com>
> 
> This driver is a bridge driver that surfaces a Mellanox device in the Linux guest and plugs into
> the "NetworkDirect" RDMA infrastructure on the Windows host. Only a subset of the ibverbs are
> implemented (this decision is based on the verbs supported by the Windows host).
> The control path is implemented over the vmbus using the NetworkDirect protocol for
> virtualized environments. The data path bypasses the guest and host kernel and the NIC is able to RDMA
> into guest addresses.
> 
> Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>
> ---
>  drivers/infiniband/Kconfig                  |    1 +
>  drivers/infiniband/hw/Makefile              |    1 +
>  drivers/infiniband/hw/vmbus-nd/Kconfig      |    5 +
>  drivers/infiniband/hw/vmbus-nd/Makefile     |    3 +
>  drivers/infiniband/hw/vmbus-nd/hvnd_addr.c  |  292 +++
>  drivers/infiniband/hw/vmbus-nd/mx_abi.h     |  232 ++
>  drivers/infiniband/hw/vmbus-nd/provider.c   | 2844 ++++++++++++++++++++++++
>  drivers/infiniband/hw/vmbus-nd/vmbus_rdma.c | 3086 +++++++++++++++++++++++++++
>  drivers/infiniband/hw/vmbus-nd/vmbus_rdma.h | 2205 +++++++++++++++++++
>  9 files changed, 8669 insertions(+), 0 deletions(-)

If your final goal is to merge this driver into Linux kernel, so I will
ask from you to do the following actions:

1. Split this patch to smaller patches to allow review.
You can see as an example - latest submission of "Add Paravirtual RDMA Driver" [1].
2. Fix licenses, magic numbers, remove creepy comments and learn about
MAINTAINERS file.
3. Use preferred for this susbsystem title format.
4. Find the relevant mailing list and maintainer for this submission and
don't add unrelated people.

Thanks.

[1] http://marc.info/?l=linux-rdma&m=146835226218818&w=2

>  create mode 100644 drivers/infiniband/hw/vmbus-nd/Kconfig
>  create mode 100644 drivers/infiniband/hw/vmbus-nd/Makefile
>  create mode 100644 drivers/infiniband/hw/vmbus-nd/hvnd_addr.c
>  create mode 100644 drivers/infiniband/hw/vmbus-nd/mx_abi.h
>  create mode 100644 drivers/infiniband/hw/vmbus-nd/provider.c
>  create mode 100644 drivers/infiniband/hw/vmbus-nd/vmbus_rdma.c
>  create mode 100644 drivers/infiniband/hw/vmbus-nd/vmbus_rdma.h

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)