linux-kernel - Re: [PATCH 1/1] UBSAN: use uppercase K to format a kernel pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 Jul 2016 12:53:11 -0700
From:	Joe Perches <joe@...ches.com>
To:	Nicolas Iooss <nicolas.iooss_linux@....org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andrey Ryabinin <aryabinin@...tuozzo.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] UBSAN: use uppercase K to format a kernel pointer

On Fri, 2016-07-29 at 13:10 +0200, Nicolas Iooss wrote:
> handle_object_size_mismatch() used %pk to format a kernel pointer in
> pr_err().  This seems to be a misspelling for %pK.

Thanks


> diff --git a/lib/ubsan.c b/lib/ubsan.c
[]
> @@ -308,7 +308,7 @@ static void handle_object_size_mismatch(struct
> type_mismatch_data *data,
>  		return;
>  
>  	ubsan_prologue(&data->location, &flags);
> -	pr_err("%s address %pk with insufficient space\n",
> +	pr_err("%s address %pK with insufficient space\n",
>  		type_check_kinds[data->type_check_kind],
>  		(void *) ptr);
>  	pr_err("for an object of type %s\n", data->type->type_name);

Maybe change this to a single output line:

	pr_err("%s address %pK with insufficient space for an object of type %s\n",
	       type_check_kinds[data->type_check_kind], (void *)ptr,
	       data->type->type_name);