linux-kernel - Re: [PATCH 1/2] ASoC: sunxi: Add bindings for sun6i to SPDIF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 30 Jul 2016 17:40:11 +0200
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	Code Kipper <codekipper@...il.com>
Cc:	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	linux-sunxi <linux-sunxi@...glegroups.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org,
	"Andrea Venturi (pers)" <be17068@...rbole.bo.it>
Subject: Re: [PATCH 1/2] ASoC: sunxi: Add bindings for sun6i to SPDIF

On Sat, Jul 30, 2016 at 05:34:11PM +0200, Code Kipper wrote:
> On 30 July 2016 at 17:17, Maxime Ripard
> <maxime.ripard@...e-electrons.com> wrote:
> > On Sat, Jul 30, 2016 at 04:27:15PM +0200, codekipper@...il.com wrote:
> >> From: Marcus Cooper <codekipper@...il.com>
> >>
> >> The A31 SoC uses the same SPDIF block as found in earlier SoCs, but its
> >> reset is controlled via a separate reset controller.
> >>
> >> Signed-off-by: Marcus Cooper <codekipper@...il.com>
> >> ---
> >>  Documentation/devicetree/bindings/sound/sunxi,sun4i-spdif.txt | 3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/sound/sunxi,sun4i-spdif.txt b/Documentation/devicetree/bindings/sound/sunxi,sun4i-spdif.txt
> >> index 13503aa..4fe80f7 100644
> >> --- a/Documentation/devicetree/bindings/sound/sunxi,sun4i-spdif.txt
> >> +++ b/Documentation/devicetree/bindings/sound/sunxi,sun4i-spdif.txt
> >> @@ -9,6 +9,7 @@ Required properties:
> >>
> >>    - compatible               : should be one of the following:
> >>      - "allwinner,sun4i-a10-spdif": for the Allwinner A10 SoC
> >> +    - "allwinner,sun6i-a31-spdif": for the Allwinner A31 SoC
> >>
> >>    - reg                      : Offset and length of the register set for the device.
> >>
> >> @@ -25,6 +26,8 @@ Required properties:
> >>       "apb"             clock for the spdif bus.
> >>       "spdif"           clock for spdif controller.
> >>
> >> +  - reset            : reset specifier for the ahb reset (A31 and newer only)
> >
> > Isn't it resets ? (plural)
> 
> Dohh..yes it is. Do you want me to send an updated patch series, a
> single patch change or could I beg for your commit massaging?

I'm not the one who is going to apply that patch, so I don't know :)

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)