linux-kernel - Re: [PATCH 0947/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 2 Aug 2016 09:51:18 -0300
From:	Mauro Carvalho Chehab <maurochehab@...il.com>
To:	Baole Ni <baolex.ni@...el.com>
Cc:	mchehab@...nel.org, mchehab@...radead.org, mchehab@...hat.com,
	m.chehab@...sung.com, gregkh@...uxfoundation.org,
	m.szyprowski@...sung.com, kyungmin.park@...sung.com,
	k.kozlowski@...sung.com, linux-media@...r.kernel.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	amitoj1606@...il.com, arnd@...db.de, hverkuil@...all.nl,
	chuansheng.liu@...el.com
Subject: Re: [PATCH 0947/1285] Replace numeric parameter like 0444 with
 macro

Em Tue,  2 Aug 2016 20:01:34 +0800
Baole Ni <baolex.ni@...el.com> escreveu:

> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.

Gah!

A patch series with 1285 patches with identical subject!

Please don't ever do something like that. My inbox is not trash!

Instead, please group the changes per subsystem, and use different
names for each patch. Makes easier for people to review.

also, you need to send the patches to the subsystem mainatiner, and
not adding a random list of people like this:

To: gregkh@...uxfoundation.org, maurochehab@...il.com, mchehab@...radead.org, mchehab@...hat.com, m.chehab@...sung.com, m.szyprowski@...sung.com, kyungmin.park@...sung.com, k.kozlowski@...sung.com

Btw, use *just* the more recent email of the maintainer, instead of
spamming trash to all our emails (even to the ones that we don't use
anymore!

I'll just send all those things to /dev/null until you fix your
email sending process.

Regards,
Mauro

> 
> Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
> Signed-off-by: Baole Ni <baolex.ni@...el.com>
> ---
>  drivers/staging/media/omap1/omap1_camera.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/omap1/omap1_camera.c b/drivers/staging/media/omap1/omap1_camera.c
> index 54b8dd2..6e125dc 100644
> --- a/drivers/staging/media/omap1/omap1_camera.c
> +++ b/drivers/staging/media/omap1/omap1_camera.c
> @@ -1692,7 +1692,7 @@ static struct platform_driver omap1_cam_driver = {
>  
>  module_platform_driver(omap1_cam_driver);
>  
> -module_param(sg_mode, bool, 0644);
> +module_param(sg_mode, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
>  MODULE_PARM_DESC(sg_mode, "videobuf mode, 0: dma-contig (default), 1: dma-sg");
>  
>  MODULE_DESCRIPTION("OMAP1 Camera Interface driver");