linux-kernel - Re: [PATCH 0986/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 02 Aug 2016 16:53:57 +0300
From:	Felipe Balbi <balbi@...nel.org>
To:	Baole Ni <baolex.ni@...el.com>, gregkh@...uxfoundation.org,
	m.chehab@...sung.com, m.szyprowski@...sung.com,
	kyungmin.park@...sung.com, k.kozlowski@...sung.com
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	chuansheng.liu@...el.com, baolex.ni@...el.com, mina86@...a86.com,
	deepa.kernel@...il.com, mathias.nyman@...ux.intel.com,
	stern@...land.harvard.edu, oneukum@...e.com
Subject: Re: [PATCH 0986/1285] Replace numeric parameter like 0444 with macro

Baole Ni <baolex.ni@...el.com> writes:

> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
> Signed-off-by: Baole Ni <baolex.ni@...el.com>
> ---
>  drivers/usb/phy/phy-tahvo.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/phy/phy-tahvo.c b/drivers/usb/phy/phy-tahvo.c
> index ab5d364..a297861 100644
> --- a/drivers/usb/phy/phy-tahvo.c
> +++ b/drivers/usb/phy/phy-tahvo.c
> @@ -73,7 +73,7 @@ static ssize_t vbus_state_show(struct device *device,
>  	struct tahvo_usb *tu = dev_get_drvdata(device);
>  	return sprintf(buf, "%s\n", tu->vbus_state ? "on" : "off");
>  }
> -static DEVICE_ATTR(vbus, 0444, vbus_state_show, NULL);
> +static DEVICE_ATTR(vbus, S_IRUSR | S_IRGRP | S_IROTH, vbus_state_show, NULL);
>  
>  static void check_vbus_state(struct tahvo_usb *tu)
>  {
> @@ -318,7 +318,7 @@ static ssize_t otg_mode_store(struct device *device,
>  
>  	return r;
>  }
> -static DEVICE_ATTR(otg_mode, 0644, otg_mode_show, otg_mode_store);
> +static DEVICE_ATTR(otg_mode, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, otg_mode_show, otg_mode_store);

line too long

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)