linux-kernel - [PATCH 0827/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue,  2 Aug 2016 19:50:16 +0800
From:	Baole Ni <baolex.ni@...el.com>
To:	bhelgaas@...gle.com, paulus@...ba.org, mpe@...erman.id.au,
	sbranden@...adcom.com, m.chehab@...sung.com, pawel@...iak.com,
	m.szyprowski@...sung.com, kyungmin.park@...sung.com,
	k.kozlowski@...sung.com
Cc:	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
	luto@...nel.org, chuansheng.liu@...el.com, baolex.ni@...el.com
Subject: [PATCH 0827/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
Signed-off-by: Baole Ni <baolex.ni@...el.com>
---
 drivers/pci/pcie/aspm.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
index 2dfe7fd..920df3f 100644
--- a/drivers/pci/pcie/aspm.c
+++ b/drivers/pci/pcie/aspm.c
@@ -814,7 +814,7 @@ static int pcie_aspm_get_policy(char *buffer, struct kernel_param *kp)
 }
 
 module_param_call(policy, pcie_aspm_set_policy, pcie_aspm_get_policy,
-	NULL, 0644);
+	NULL, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 
 #ifdef CONFIG_PCIEASPM_DEBUG
 static ssize_t link_state_show(struct device *dev,
@@ -886,8 +886,8 @@ static ssize_t clk_ctl_store(struct device *dev,
 	return n;
 }
 
-static DEVICE_ATTR(link_state, 0644, link_state_show, link_state_store);
-static DEVICE_ATTR(clk_ctl, 0644, clk_ctl_show, clk_ctl_store);
+static DEVICE_ATTR(link_state, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, link_state_show, link_state_store);
+static DEVICE_ATTR(clk_ctl, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, clk_ctl_show, clk_ctl_store);
 
 static char power_group[] = "power";
 void pcie_aspm_create_sysfs_dev_files(struct pci_dev *pdev)
-- 
2.9.2