linux-kernel - [PATCH 0896/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue,  2 Aug 2016 19:56:06 +0800
From:	Baole Ni <baolex.ni@...el.com>
To:	ubraun@...ux.vnet.ibm.com, schwidefsky@...ibm.com,
	heiko.carstens@...ibm.com, dwmw2@...radead.org,
	m.chehab@...sung.com, pawel@...iak.com, m.szyprowski@...sung.com,
	kyungmin.park@...sung.com, k.kozlowski@...sung.com
Cc:	linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
	chuansheng.liu@...el.com, baolex.ni@...el.com
Subject: [PATCH 0896/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
Signed-off-by: Baole Ni <baolex.ni@...el.com>
---
 drivers/s390/net/qeth_l2_sys.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/s390/net/qeth_l2_sys.c b/drivers/s390/net/qeth_l2_sys.c
index 692db49..926d584 100644
--- a/drivers/s390/net/qeth_l2_sys.c
+++ b/drivers/s390/net/qeth_l2_sys.c
@@ -100,7 +100,7 @@ static ssize_t qeth_bridge_port_role_store(struct device *dev,
 	return rc ? rc : count;
 }
 
-static DEVICE_ATTR(bridge_role, 0644, qeth_bridge_port_role_show,
+static DEVICE_ATTR(bridge_role, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, qeth_bridge_port_role_show,
 		   qeth_bridge_port_role_store);
 
 static ssize_t qeth_bridge_port_state_show(struct device *dev,
@@ -109,7 +109,7 @@ static ssize_t qeth_bridge_port_state_show(struct device *dev,
 	return qeth_bridge_port_role_state_show(dev, attr, buf, 1);
 }
 
-static DEVICE_ATTR(bridge_state, 0444, qeth_bridge_port_state_show,
+static DEVICE_ATTR(bridge_state, S_IRUSR | S_IRGRP | S_IROTH, qeth_bridge_port_state_show,
 		   NULL);
 
 static ssize_t qeth_bridgeport_hostnotification_show(struct device *dev,
@@ -157,7 +157,7 @@ static ssize_t qeth_bridgeport_hostnotification_store(struct device *dev,
 	return rc ? rc : count;
 }
 
-static DEVICE_ATTR(bridge_hostnotify, 0644,
+static DEVICE_ATTR(bridge_hostnotify, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH,
 			qeth_bridgeport_hostnotification_show,
 			qeth_bridgeport_hostnotification_store);
 
@@ -218,7 +218,7 @@ static ssize_t qeth_bridgeport_reflect_store(struct device *dev,
 	return rc ? rc : count;
 }
 
-static DEVICE_ATTR(bridge_reflect_promisc, 0644,
+static DEVICE_ATTR(bridge_reflect_promisc, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH,
 			qeth_bridgeport_reflect_show,
 			qeth_bridgeport_reflect_store);
 
-- 
2.9.2