linux-kernel - [PATCH 0527/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue,  2 Aug 2016 19:21:03 +0800
From:	Baole Ni <baolex.ni@...el.com>
To:	mchehab@...nel.org, maurochehab@...il.com, mchehab@...radead.org,
	mchehab@...hat.com, m.chehab@...sung.com, corbet@....net,
	s.nawrocki@...sung.com, kgene@...nel.org, k.kozlowski@...sung.com
Cc:	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	chuansheng.liu@...el.com, baolex.ni@...el.com,
	jh1009.sung@...sung.com, nenggun.kim@...sung.com
Subject: [PATCH 0527/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
Signed-off-by: Baole Ni <baolex.ni@...el.com>
---
 drivers/media/platform/marvell-ccic/mcam-core.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/media/platform/marvell-ccic/mcam-core.c b/drivers/media/platform/marvell-ccic/mcam-core.c
index 9b878de..4b3515c 100644
--- a/drivers/media/platform/marvell-ccic/mcam-core.c
+++ b/drivers/media/platform/marvell-ccic/mcam-core.c
@@ -47,7 +47,7 @@
  */
 
 static bool alloc_bufs_at_read;
-module_param(alloc_bufs_at_read, bool, 0444);
+module_param(alloc_bufs_at_read, bool, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(alloc_bufs_at_read,
 		"Non-zero value causes DMA buffers to be allocated when the "
 		"video capture device is read, rather than at module load "
@@ -56,13 +56,13 @@ MODULE_PARM_DESC(alloc_bufs_at_read,
 		"only used in the vmalloc buffer mode");
 
 static int n_dma_bufs = 3;
-module_param(n_dma_bufs, uint, 0644);
+module_param(n_dma_bufs, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(n_dma_bufs,
 		"The number of DMA buffers to allocate.  Can be either two "
 		"(saves memory, makes timing tighter) or three.");
 
 static int dma_buf_size = VGA_WIDTH * VGA_HEIGHT * 2;  /* Worst case */
-module_param(dma_buf_size, uint, 0444);
+module_param(dma_buf_size, uint, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(dma_buf_size,
 		"The size of the allocated DMA buffers.  If actual operating "
 		"parameters require larger buffers, an attempt to reallocate "
@@ -73,13 +73,13 @@ static const int n_dma_bufs = 3;  /* Used by S/G_PARM */
 #endif /* MCAM_MODE_VMALLOC */
 
 static bool flip;
-module_param(flip, bool, 0444);
+module_param(flip, bool, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(flip,
 		"If set, the sensor will be instructed to flip the image "
 		"vertically.");
 
 static int buffer_mode = -1;
-module_param(buffer_mode, int, 0444);
+module_param(buffer_mode, int, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(buffer_mode,
 		"Set the buffer mode to be used; default is to go with what "
 		"the platform driver asks for.  Set to 0 for vmalloc, 1 for "
-- 
2.9.2