linux-kernel - Re: [PATCH 34/34] Staging: comedi: drivers: cd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 2 Aug 2016 18:42:38 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	Nadim almas <nadim.902@...il.com>
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	devel@...verdev.osuosl.org
Subject: Re: [PATCH 34/34] Staging: comedi: drivers: cd_pcidas: Compression of

On 30/07/16 21:04, Nadim almas wrote:
> This patch compresses two lines in to a single line in file
> cb_pcidas.c

But this patch changes cb_pcidas64.c.  Also, the Subject line says 
'cd_pcidas'.

You can remove the 'drivers:' tag from the subject line to save some 
space.  It is sufficient to tag it as 'Staging: comedi: cb_pcidas64:'.

> if immediate return statement is found. It also removes variable
> bytes_written as it is no longer needed.

The patch does not remove any variables.

> It is done using script Coccinelle. And coccinelle uses following
> semantic patch for this compression function:
>
> @@
> expression e, ret;
> @@
>
> -ret =
> +return
>      e;
> -return ret
>
> Signed-off-by: Nadim Almas <nadim.902@...il.com>
> ---
>
>  drivers/staging/comedi/drivers/cb_pcidas64.c | 4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
>
>
>
> diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
> index 1f9c08a..d30cf3d 100644
> --- a/drivers/staging/comedi/drivers/cb_pcidas64.c
> +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
> @@ -1408,9 +1408,7 @@ static int set_ai_fifo_size(struct comedi_device *dev, unsigned int num_samples)
>  	if (retval < 0)
>  		return retval;
>
> -	num_samples = retval * fifo->num_segments * fifo->sample_packing_ratio;
> -
> -	return num_samples;
> +	return retval * fifo->num_segments * fifo->sample_packing_ratio;
>  }
>
>  /* query length of fifo */
>


-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-