linux-kernel - Re: [PATCH] ASoC: simple-card-utils: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 2 Aug 2016 19:11:14 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Cc:	Kevin Hilman <khilman@...libre.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	alsa-devel@...a-project.org, Sekhar Nori <nsekhar@...com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: simple-card-utils: add missing MODULE_xxx()

On Tue, Aug 02, 2016 at 03:22:08AM +0000, Kuninori Morimoto wrote:

> +MODULE_AUTHOR("Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>");
> +MODULE_DESCRIPTION("ALSA SoC Simple Card Utils");
> +MODULE_LICENSE("GPL v2");

This lot is what is needed (well, just the MODULE_LICENSE).

> +MODULE_ALIAS("platform:asoc-simple-card-utils");

This is wrong, this isn't a driver but rather a library that's used by
other modules so it shouldn't have an alias.  The aliases are there to
let modutils know which module to load for a device that it sees.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)