linux-kernel - Re: [PATCH 1038/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 2 Aug 2016 17:17:02 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Baole Ni <baolex.ni@...el.com>
Cc:	adilger.kernel@...ger.ca, david.vrabel@...rix.com,
	tomi.valkeinen@...com, m.chehab@...sung.com,
	gregkh@...uxfoundation.org, m.szyprowski@...sung.com,
	kyungmin.park@...sung.com, k.kozlowski@...sung.com,
	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
	chuansheng.liu@...el.com, mhalcrow@...gle.com,
	kirill.shutemov@...ux.intel.com, oneukum@...e.com
Subject: Re: [PATCH 1038/1285] Replace numeric parameter like 0444 with macro

On Tue, Aug 02, 2016 at 08:10:47PM +0800, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.

I actually find using the macros significantly **decrease* the
readiability of the code.  A quick glance at 0644 quickly tells you
what the permissions are.  Parsing S_IRUSR | S_IRGRP | S_IROTH takes
longer, and is more error prone.

NACK.

					- Ted