linux-kernel - [PATCH 0225/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue,  2 Aug 2016 18:51:12 +0800
From:	Baole Ni <baolex.ni@...el.com>
To:	erazor_de@...rs.sourceforge.net, jikos@...nel.org,
	benjamin.tissoires@...hat.com, airlied@...ux.ie, kgene@...nel.org,
	k.kozlowski@...sung.com, dougthompson@...ssion.com, bp@...en8.de
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	chuansheng.liu@...el.com, baolex.ni@...el.com,
	alexander.deucher@....com, ville.syrjala@...ux.intel.com
Subject: [PATCH 0225/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
Signed-off-by: Baole Ni <baolex.ni@...el.com>
---
 drivers/hid/hid-roccat-arvo.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/hid/hid-roccat-arvo.c b/drivers/hid/hid-roccat-arvo.c
index 329c5d1..680d339 100644
--- a/drivers/hid/hid-roccat-arvo.c
+++ b/drivers/hid/hid-roccat-arvo.c
@@ -75,7 +75,7 @@ static ssize_t arvo_sysfs_set_mode_key(struct device *dev,
 
 	return size;
 }
-static DEVICE_ATTR(mode_key, 0660,
+static DEVICE_ATTR(mode_key, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP,
 		   arvo_sysfs_show_mode_key, arvo_sysfs_set_mode_key);
 
 static ssize_t arvo_sysfs_show_key_mask(struct device *dev,
@@ -125,7 +125,7 @@ static ssize_t arvo_sysfs_set_key_mask(struct device *dev,
 
 	return size;
 }
-static DEVICE_ATTR(key_mask, 0660,
+static DEVICE_ATTR(key_mask, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP,
 		   arvo_sysfs_show_key_mask, arvo_sysfs_set_key_mask);
 
 /* retval is 1-5 on success, < 0 on error */
@@ -183,7 +183,7 @@ static ssize_t arvo_sysfs_set_actual_profile(struct device *dev,
 	mutex_unlock(&arvo->arvo_lock);
 	return retval;
 }
-static DEVICE_ATTR(actual_profile, 0660,
+static DEVICE_ATTR(actual_profile, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP,
 		   arvo_sysfs_show_actual_profile,
 		   arvo_sysfs_set_actual_profile);
 
@@ -235,7 +235,7 @@ static ssize_t arvo_sysfs_write_button(struct file *fp,
 	return arvo_sysfs_write(fp, kobj, buf, off, count,
 			sizeof(struct arvo_button), ARVO_COMMAND_BUTTON);
 }
-static BIN_ATTR(button, 0220, NULL, arvo_sysfs_write_button,
+static BIN_ATTR(button, S_IWUSR | S_IWGRP, NULL, arvo_sysfs_write_button,
 		sizeof(struct arvo_button));
 
 static ssize_t arvo_sysfs_read_info(struct file *fp,
@@ -245,7 +245,7 @@ static ssize_t arvo_sysfs_read_info(struct file *fp,
 	return arvo_sysfs_read(fp, kobj, buf, off, count,
 			sizeof(struct arvo_info), ARVO_COMMAND_INFO);
 }
-static BIN_ATTR(info, 0440, arvo_sysfs_read_info, NULL,
+static BIN_ATTR(info, S_IRUSR | S_IRGRP, arvo_sysfs_read_info, NULL,
 		sizeof(struct arvo_info));
 
 static struct attribute *arvo_attrs[] = {
-- 
2.9.2