linux-kernel - Re: [PATCH v2 RESEND] fs: return EPERM on immutable inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 2 Aug 2016 05:28:08 -0700
From:	Christoph Hellwig <hch@...radead.org>
To:	Eryu Guan <guaneryu@...il.com>
Cc:	linux-fsdevel@...r.kernel.org,
	open list <linux-kernel@...r.kernel.org>,
	"supporter:XFS FILESYSTEM" <xfs@....sgi.com>,
	"open list:GFS2 FILE SYSTEM" <cluster-devel@...hat.com>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Bob Peterson <rpeterso@...hat.com>,
	Steven Whitehouse <swhiteho@...hat.com>
Subject: Re: [PATCH v2 RESEND] fs: return EPERM on immutable inode

On Tue, Aug 02, 2016 at 07:58:28PM +0800, Eryu Guan wrote:
> In most cases, EPERM is returned on immutable inode, and there're only a
> few places returning EACCES. I noticed this when running LTP on
> overlayfs, setxattr03 failed due to unexpected EACCES on immutable
> inode.
> 
> So converting all EACCES to EPERM on immutable inode.

Looks fine,

Reviewed-by: Christoph Hellwig <hch@....de>

Although maybe you'll have to split this into one patch per subsystems,
as otherwise no maintainer might be enticed to pick it up.