linux-kernel - [PATCH 0994/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue,  2 Aug 2016 20:06:16 +0800
From:	Baole Ni <baolex.ni@...el.com>
To:	michael.hennerich@...log.com, jingoohan1@...il.com,
	lee.jones@...aro.org, plagnioj@...osoft.com, tomi.valkeinen@...com,
	m.chehab@...sung.com, gregkh@...uxfoundation.org,
	m.szyprowski@...sung.com, kyungmin.park@...sung.com,
	k.kozlowski@...sung.com
Cc:	linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	chuansheng.liu@...el.com, baolex.ni@...el.com,
	mathias.nyman@...ux.intel.com, stern@...land.harvard.edu,
	oneukum@...e.com
Subject: [PATCH 0994/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
Signed-off-by: Baole Ni <baolex.ni@...el.com>
---
 drivers/video/backlight/adp8860_bl.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c
index 510e559..d0cf892 100644
--- a/drivers/video/backlight/adp8860_bl.c
+++ b/drivers/video/backlight/adp8860_bl.c
@@ -473,7 +473,7 @@ static ssize_t adp8860_bl_l3_dark_max_store(struct device *dev,
 	return adp8860_store(dev, buf, count, ADP8860_BLMX3);
 }
 
-static DEVICE_ATTR(l3_dark_max, 0664, adp8860_bl_l3_dark_max_show,
+static DEVICE_ATTR(l3_dark_max, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH, adp8860_bl_l3_dark_max_show,
 			adp8860_bl_l3_dark_max_store);
 
 static ssize_t adp8860_bl_l2_office_max_show(struct device *dev,
@@ -487,7 +487,7 @@ static ssize_t adp8860_bl_l2_office_max_store(struct device *dev,
 {
 	return adp8860_store(dev, buf, count, ADP8860_BLMX2);
 }
-static DEVICE_ATTR(l2_office_max, 0664, adp8860_bl_l2_office_max_show,
+static DEVICE_ATTR(l2_office_max, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH, adp8860_bl_l2_office_max_show,
 			adp8860_bl_l2_office_max_store);
 
 static ssize_t adp8860_bl_l1_daylight_max_show(struct device *dev,
@@ -507,7 +507,7 @@ static ssize_t adp8860_bl_l1_daylight_max_store(struct device *dev,
 
 	return adp8860_store(dev, buf, count, ADP8860_BLMX1);
 }
-static DEVICE_ATTR(l1_daylight_max, 0664, adp8860_bl_l1_daylight_max_show,
+static DEVICE_ATTR(l1_daylight_max, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH, adp8860_bl_l1_daylight_max_show,
 			adp8860_bl_l1_daylight_max_store);
 
 static ssize_t adp8860_bl_l3_dark_dim_show(struct device *dev,
@@ -522,7 +522,7 @@ static ssize_t adp8860_bl_l3_dark_dim_store(struct device *dev,
 {
 	return adp8860_store(dev, buf, count, ADP8860_BLDM3);
 }
-static DEVICE_ATTR(l3_dark_dim, 0664, adp8860_bl_l3_dark_dim_show,
+static DEVICE_ATTR(l3_dark_dim, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH, adp8860_bl_l3_dark_dim_show,
 			adp8860_bl_l3_dark_dim_store);
 
 static ssize_t adp8860_bl_l2_office_dim_show(struct device *dev,
@@ -537,7 +537,7 @@ static ssize_t adp8860_bl_l2_office_dim_store(struct device *dev,
 {
 	return adp8860_store(dev, buf, count, ADP8860_BLDM2);
 }
-static DEVICE_ATTR(l2_office_dim, 0664, adp8860_bl_l2_office_dim_show,
+static DEVICE_ATTR(l2_office_dim, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH, adp8860_bl_l2_office_dim_show,
 			adp8860_bl_l2_office_dim_store);
 
 static ssize_t adp8860_bl_l1_daylight_dim_show(struct device *dev,
@@ -552,7 +552,7 @@ static ssize_t adp8860_bl_l1_daylight_dim_store(struct device *dev,
 {
 	return adp8860_store(dev, buf, count, ADP8860_BLDM1);
 }
-static DEVICE_ATTR(l1_daylight_dim, 0664, adp8860_bl_l1_daylight_dim_show,
+static DEVICE_ATTR(l1_daylight_dim, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH, adp8860_bl_l1_daylight_dim_show,
 			adp8860_bl_l1_daylight_dim_store);
 
 #ifdef ADP8860_EXT_FEATURES
@@ -580,7 +580,7 @@ static ssize_t adp8860_bl_ambient_light_level_show(struct device *dev,
 
 	return sprintf(buf, "%u\n", ret_val);
 }
-static DEVICE_ATTR(ambient_light_level, 0444,
+static DEVICE_ATTR(ambient_light_level, S_IRUSR | S_IRGRP | S_IROTH,
 		adp8860_bl_ambient_light_level_show, NULL);
 
 static ssize_t adp8860_bl_ambient_light_zone_show(struct device *dev,
@@ -634,7 +634,7 @@ static ssize_t adp8860_bl_ambient_light_zone_store(struct device *dev,
 
 	return count;
 }
-static DEVICE_ATTR(ambient_light_zone, 0664,
+static DEVICE_ATTR(ambient_light_zone, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH,
 		adp8860_bl_ambient_light_zone_show,
 		adp8860_bl_ambient_light_zone_store);
 #endif
-- 
2.9.2