linux-kernel - Re: [PATCH v2 1/2] ARM: dts: Remove use of skeleton.dtsi from bcm283x.dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 3 Aug 2016 18:57:01 +0200 (CEST)
From:	Stefan Wahren <stefan.wahren@...e.com>
To:	Ian Campbell <ijc@...lion.org.uk>,
	linux-arm-kernel@...ts.infradead.org
Cc:	Will Deacon <will.deacon@....com>, Lee Jones <lee@...nel.org>,
	Frank Rowand <frowand.list@...il.com>,
	Gerd Hoffmann <kraxel@...hat.com>,
	Eric Anholt <eric@...olt.net>, linux-kernel@...r.kernel.org,
	Rob Herring <robh+dt@...nel.org>,
	Catalin Marinas <catalin.marinas@....com>, arm@...nel.org,
	Stephen Warren <swarren@...dotorg.org>,
	Mark Rutland <mark.rutland@....com>,
	linux-rpi-kernel@...ts.infradead.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 1/2] ARM: dts: Remove use of skeleton.dtsi from
 bcm283x.dtsi

Hi Ian,

> Ian Campbell <ijc@...lion.org.uk> hat am 3. August 2016 um 16:12 geschrieben:
> 
> 
> This file is included from DTS files under arch/arm64 too (via
> broadcom/bcm2837-rpi-3-b.dts and broadcom/bcm2837.dtsi). There is a desire
> not to have skeleton.dtsi for ARM64. See commit 3ebee5a2e141 ("arm64: dts:
> kill skeleton.dtsi") for rationale for its removal.
> 
> As well as the addition of #*-cells also requires adding the device_type to
> the rpi memory node explicitly.
> 
> Note that this change results in the removal of an empty /aliases node from
> bcm2835-rpi-a.dtb and bcm2835-rpi-a-plus.dtb. I have no hardware to check
> if this is a problem or not.
> 
> It also results in some reordering of the nodes in the DTBs (the /aliases
> and /memory nodes come later). This isn't supposed to matter but, again,
> I've no hardware to check if it is true in this particular case.

i tested this patch with a Raspberry Pi Model B successfully.

Tested-by: Stefan Wahren <stefan.wahren@...e.com>