linux-kernel - Re: [RFC PATCH 3/4] usb: typec: USB Type-C Port Manager (tcpm)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 3 Aug 2016 11:46:18 -0700
From:	Guenter Roeck <groeck@...gle.com>
To:	Oliver Neukum <oneukum@...e.com>
Cc:	Guenter Roeck <groeck@...omium.org>,
	Felipe Balbi <felipe.balbi@...ux.intel.com>,
	Bin Gao <bin.gao@...el.com>,
	Chandra Sekhar Anagani <chandra.sekhar.anagani@...el.com>,
	Pranav Tipnis <pranav.tipnis@...el.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-usb@...r.kernel.org,
	Bruce Ashfield <bruce.ashfield@...driver.com>
Subject: Re: [RFC PATCH 3/4] usb: typec: USB Type-C Port Manager (tcpm)

On Wed, Aug 3, 2016 at 2:28 AM, Oliver Neukum <oneukum@...e.com> wrote:
> On Tue, 2016-08-02 at 13:32 -0700, Guenter Roeck wrote:
>> +static bool svdm_consume_svids(struct tcpm_port *port, const u32
>> *payload,
>> +                              int cnt)
>> +{
>> +       struct pd_mode_data *pmdata = &port->mode_data;
>> +       int i;
>> +
>> +       for (i = 1; i < cnt; i++) {
>> +               u16 svid;
>> +
>> +               svid = (payload[i] >> 16) & 0xffff;
>> +               if (!svid)
>> +                       return false;
>
> Hi,
>
> this looks like an endianness bug.
>

Yes, you are right, and there are lots of those in my code. Thanks for
bringing it up.

Guenter