linux-kernel - Re: get_maintainer.pl and .mailmap entries with more than 2 addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 2 Aug 2016 21:50:06 -0300
From:	Mauro Carvalho Chehab <mchehab@...pensource.com>
To:	Florian Mickler <florian@...kler.org>
Cc:	Joe Perches <joe@...ches.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Shuah Khan <shuah@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>, git <git@...r.kernel.org>
Subject: Re: get_maintainer.pl and .mailmap entries with more than 2
 addresses

Em Wed, 03 Aug 2016 00:17:10 +0200
Florian Mickler <florian@...kler.org> escreveu:

> cc'd mchehab@...pensource.com  (Mauro, is your kernel.org address up?)

Yes, my kernel.org address is up. Better to keep it as the canonical address,
as this is unlikely to change as it is not associated to an e-mail provider.

> 
>  Am Tue, 02 Aug 2016 09:36:21 -0700
> schrieb Joe Perches <joe@...ches.com>:
> 
> > Hello Florian.
> > 
> > There is at least an oddity with get_maintainer handling of a
> > .mailmap entry form.
> > 
> > For instance:
> > 
> > Mauro's .mailmap entry is:
> > Mauro Carvalho Chehab <mchehab@...nel.org> <maurochehab@...il.com>
> > <mchehab@...radead.org> <mchehab@...hat.com> <m.chehab@...sung.com>
> > <mchehab@....samsung.com> <mchehab@...pensource.com>
> > 
> > Is this a valid form?
> > 
> > get_maintainer output for Mauro is:
> > 
> > $ ./scripts/get_maintainer.pl drivers/media/ -f
> > Mauro Carvalho Chehab <mchehab@...nel.org> <maurochehab@...il.com>
> > <mchehab@...radead.org> <mchehab@...hat.com> <m.chehab@...sung.com>
> > <mchehab@....samsung.com> (maintainer:MEDIA INPUT INFRASTRUCTURE
> > (V4L/DVB))
> > 
> > I believe the Mauro's and Shuah's .mailmap entries are improper and
> > should be changed, but I'm not completely aware of git .mailmap
> > handling and the documentation seems weakly specified.
> >   
> 
> Hmm.. looking at Mauros last .mailmap commit it seems like your patch is
> ok for Mauro. 
> 
> Although <mywing81@...il.com> and <mchehab@...urbo.com.br> are probably
> missing? (@Mauro) 

The mchehab@...urbo.com.br is indeed an old email that I used on my
first submissions.

I don't know a mywing81@...il.com address... that looks really weird
on my eyes...

Hmm...

$ git log --author "mywing81@...il.com"
commit fe8b671306c78a963934cb5d6e354178390b8c87
Author: Mauro Carvalho Chehab <mywing81@...il.com>
Date:   Thu Sep 30 14:46:47 2010 -0300

    [media] saa7134: port Asus P7131 Hybrid to use the new rc-core
    
    The rc map table were corrected thanks to Giorgio input and tests.
    
    Reported-by: Giorgio Vazzana <mywing81@...il.com>
    Tested-by: Giorgio Vazzana <mywing81@...il.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@...hat.com>

I don't remember the dirty details about such patch anymore... too
many years ago. From the custody chain, I _suspect_ that Giorgio
proposed a patch to be applied against the saa7134 driver, but the 
remote controller map table was moved to a separate file about 7
months before such patch by those changesets:

6686fa6917ca V4L/DVB: Break Remote Controller keymaps into modules
77b7422d48cd V4L/DVB: ir-common: move IR tables from ir-keymaps.c to a separate file

I likely rewrote his patch against the new driver, but somehow
I mangled with the author name/email. In any case, mywing81@...il.com
should not be associated with me.
 
> <snip console research ... >
> $ git shortlog | grep "^Mauro C"
> Mauro Carvalho Chehab (4404):
> $ git log | grep "^Author:.*Mauro Carvalho Chehab" | sort | uniq -c
>       2 Author: Mauro Carvalho Chehab <maurochehab@...il.com>
>     146 Author: Mauro Carvalho Chehab <mchehab@...urbo.com.br>
>     645 Author: Mauro Carvalho Chehab <mchehab@...radead.org>
>     794 Author: Mauro Carvalho Chehab <mchehab@....samsung.com>
>    2015 Author: Mauro Carvalho Chehab <mchehab@...hat.com>
>     448 Author: Mauro Carvalho Chehab <m.chehab@...sung.com>
>     353 Author: Mauro Carvalho Chehab <mchehab@...pensource.com>

All above are my e-mails. Let's point them all to mchehab@...nel.org.

>       1 Author: Mauro Carvalho Chehab <mywing81@...il.com>

This one is mangled and doesn't belong to me. So, it shouldn't be
at the .mailmap file.

> </snip>
> 
> 
> Anyway, from a technical viewpoint your patches seem to fix
> the .mailmap entry as the author intended. (See Junio's Email for the
> documantation part) 
> But I would wait for the ack from Mauro and Shuah. 

With the above changes,

Acked-by: Mauro Carvalho Chehab <mchehab@...pensource.com>


Thanks,
Mauro