linux-kernel - Re: [PATCH 1/1] blk-mq: fix hang caused by freeze/unfreeze sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 6 Aug 2016 02:28:43 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Roman Pen <roman.penyaev@...fitbricks.com>
Cc:	kbuild-all@...org, Roman Pen <roman.penyaev@...fitbricks.com>,
	Akinobu Mita <akinobu.mita@...il.com>,
	Tejun Heo <tj@...nel.org>, Jens Axboe <axboe@...nel.dk>,
	Christoph Hellwig <hch@....de>, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] blk-mq: fix hang caused by freeze/unfreeze sequence

Hi Roman,

[auto build test WARNING on block/for-next]
[also build test WARNING on v4.7 next-20160805]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Roman-Pen/blk-mq-fix-hang-caused-by-freeze-unfreeze-sequence/20160806-014441
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: tile-allyesconfig (attached as .config)
compiler: tilegx-linux-gcc (GCC) 4.6.2
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=tile 

All warnings (new ones prefixed by >>):

   block/blk-core.c: In function 'blk_queue_enter':
>> block/blk-core.c:660:3: warning: passing argument 1 of 'atomic_read' from incompatible pointer type [enabled by default]
   arch/tile/include/asm/atomic.h:35:19: note: expected 'const struct atomic_t *' but argument is of type 'int *'
>> block/blk-core.c:660:3: warning: passing argument 1 of 'atomic_read' from incompatible pointer type [enabled by default]
   arch/tile/include/asm/atomic.h:35:19: note: expected 'const struct atomic_t *' but argument is of type 'int *'

vim +/atomic_read +660 block/blk-core.c

^1da177e drivers/block/ll_rw_blk.c Linus Torvalds    2005-04-16  644  {
c304a51b block/blk-core.c          Ezequiel Garcia   2012-11-10  645  	return blk_alloc_queue_node(gfp_mask, NUMA_NO_NODE);
1946089a drivers/block/ll_rw_blk.c Christoph Lameter 2005-06-23  646  }
1946089a drivers/block/ll_rw_blk.c Christoph Lameter 2005-06-23  647  EXPORT_SYMBOL(blk_alloc_queue);
^1da177e drivers/block/ll_rw_blk.c Linus Torvalds    2005-04-16  648  
6f3b0e8b block/blk-core.c          Christoph Hellwig 2015-11-26  649  int blk_queue_enter(struct request_queue *q, bool nowait)
3ef28e83 block/blk-core.c          Dan Williams      2015-10-21  650  {
3ef28e83 block/blk-core.c          Dan Williams      2015-10-21  651  	while (true) {
3ef28e83 block/blk-core.c          Dan Williams      2015-10-21  652  		int ret;
3ef28e83 block/blk-core.c          Dan Williams      2015-10-21  653  
3ef28e83 block/blk-core.c          Dan Williams      2015-10-21  654  		if (percpu_ref_tryget_live(&q->q_usage_counter))
3ef28e83 block/blk-core.c          Dan Williams      2015-10-21  655  			return 0;
3ef28e83 block/blk-core.c          Dan Williams      2015-10-21  656  
6f3b0e8b block/blk-core.c          Christoph Hellwig 2015-11-26  657  		if (nowait)
3ef28e83 block/blk-core.c          Dan Williams      2015-10-21  658  			return -EBUSY;
3ef28e83 block/blk-core.c          Dan Williams      2015-10-21  659  
3ef28e83 block/blk-core.c          Dan Williams      2015-10-21 @660  		ret = wait_event_interruptible(q->mq_freeze_wq,
3ef28e83 block/blk-core.c          Dan Williams      2015-10-21  661  				!atomic_read(&q->mq_freeze_depth) ||
3ef28e83 block/blk-core.c          Dan Williams      2015-10-21  662  				blk_queue_dying(q));
3ef28e83 block/blk-core.c          Dan Williams      2015-10-21  663  		if (blk_queue_dying(q))
3ef28e83 block/blk-core.c          Dan Williams      2015-10-21  664  			return -ENODEV;
3ef28e83 block/blk-core.c          Dan Williams      2015-10-21  665  		if (ret)
3ef28e83 block/blk-core.c          Dan Williams      2015-10-21  666  			return ret;
3ef28e83 block/blk-core.c          Dan Williams      2015-10-21  667  	}
3ef28e83 block/blk-core.c          Dan Williams      2015-10-21  668  }

:::::: The code at line 660 was first introduced by commit
:::::: 3ef28e83ab15799742e55fd13243a5f678b04242 block: generic request_queue reference counting

:::::: TO: Dan Williams <dan.j.williams@...el.com>
:::::: CC: Jens Axboe <axboe@...com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (44909 bytes)