linux-kernel - Re: [PATCH] scripts/Lindent: clean up and optimize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 07 Aug 2016 09:18:31 -0700
From:	Joe Perches <joe@...ches.com>
To:	Jean Delvare <jdelvare@...e.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] scripts/Lindent: clean up and optimize

On Sun, 2016-08-07 at 17:48 +0200, Jean Delvare wrote:
> Hi Joe,
> 
> On Fri, 05 Aug 2016 10:53:19 -0700, Joe Perches wrote:
> > 
> > On Fri, 2016-08-05 at 11:26 +0200, Jean Delvare wrote:
> > > 
> > > * Add a few blank lines to improve readability.
> > > * Don't call cut 3 times when once is enough.
> > > * Drop a useless semicolon.
> > As it commonly reflows > 80 column code very badly,
> > my preference would be to remove Lindent instead.
> > 
> > https://lkml.org/lkml/2013/2/11/390
> This was 3.5 years ago, so apparently it's not happening.
>
> Why don't you just remove -l80 from the options, if this is your only
> concern with the script?

line length is not context aware and you'd get > 256
column lines in a lot of cases.

>  Adding the appropriate option to indent to
> support what we think is good would seem even better, but I do not have
> any time to devote to this task.

Nor does anyone else.
indent has had 1 change in 14 years.

clang-format might be a better tool and a better
suggestion than Lindent now.