[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 8 Aug 2016 10:14:51 +0800
From: Dave Young <dyoung@...hat.com>
To: Zhou Wenjian <zhouwj-fnst@...fujitsu.com>
Cc: linux-kernel@...r.kernel.org, d.hatayama@...fujitsu.com,
kexec@...ts.infradead.org, bhe@...hat.com
Subject: Re: [PATCH v3 1/2] Documentation: kdump: remind user of nr_cpus
On 08/03/16 at 08:59am, Zhou Wenjian wrote:
> v2->v3: add description of nr_cpus.
> v1->v2: change nr_cpus to maxcpus
>
> nr_cpus can help to save memory. So we should remind user of it.
>
> Signed-off-by: Zhou Wenjian <zhouwj-fnst@...fujitsu.com>
> ---
> Documentation/kdump/kdump.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/kdump/kdump.txt b/Documentation/kdump/kdump.txt
> index 88ff63d..4aa194e 100644
> --- a/Documentation/kdump/kdump.txt
> +++ b/Documentation/kdump/kdump.txt
> @@ -393,6 +393,8 @@ Notes on loading the dump-capture kernel:
> * We generally don' have to bring up a SMP kernel just to capture the
> dump. Hence generally it is useful either to build a UP dump-capture
> kernel or specify maxcpus=1 option while loading dump-capture kernel.
> + Note, though maxcpus always works, we should replace it by nr_cpus to
> + save memory if supported by the current ARCH, such as x86.
Can you replace "we" with "you" in both these patches?
Thanks
Dave
Powered by blists - more mailing lists