linux-kernel - Re: [PATCH 0/2] mfd: cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 8 Aug 2016 12:30:18 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc:	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Tomeu Vizoso <tomeu.vizoso@...labora.com>,
	Vic Yang <victoryang@...gle.com>,
	Olof Johansson <olof@...om.net>,
	Gwendal Grignou <gwendal@...omium.org>,
	Brian Norris <briannorris@...omium.org>
Subject: Re: [PATCH 0/2] mfd: cros_ec_keyb: MKBP event support

On Fri, 01 Jul 2016, Enric Balletbo i Serra wrote:
> Hi,
> 
> The cros-ec MKBP event support will be used on different EC drivers like EC
> keyboard, EC USB PD and EC sensors drivers. The first attempt to merge these two
> patches was within the EC USB PD series [1] sent by Tomeu Vizoso, but these
> series are blocked possibly until we figure out how this maps into the proposed
> type-c infraestructure.
> 
> As these patches ([2] and [3]) were a dependency for other possible patch
> series and have sense send it alone, makes no sense wait for the upstreaming of
> the full EC USB PD series, so I created a new patch series with only these two
> patches and rid of the USB PD stuff.
> 
> Note that the following patch series apply cleanly on top of mainline plus the
> patches to add support for ChromeOS EC PWM by Brian Norris [4] to avoid
> conflicts and because I think are close to be accepted.
> 
> Also note that the two patches need to be taken together, massively reducing the
> chances of a fail.  The chances that a) a bisect will fall exactly between the
> 2 patches and then b) the drivers try to handle the same interrupt at the same
> time are significantly small enough for us to take that risk.
> 
> The patches were tested by myself on a Veyron Jerry checking that after some
> suspend/resumes cycles the keyboard is working.
> 
> Changes:
>  * Add the SoB Vic Yang
>  * Rebased on top of mainline + cros_ec pwm patches, resolved the conflicts.
> 
> [1] https://lwn.net/Articles/679228/
> [2] https://patchwork.kernel.org/patch/8809921/
> [3] https://patchwork.kernel.org/patch/8809931/
> [4] https://lwn.net/Articles/691861/
> 
> Vic Yang (2):
>   mfd: cros_ec: Add MKBP event support
>   Input: cros_ec_keyb - Stop handling interrupts directly
> 
>  drivers/input/keyboard/cros_ec_keyb.c   | 135 ++++++++------------------------
>  drivers/mfd/cros_ec.c                   |  58 +++++++++++++-
>  drivers/platform/chrome/cros_ec_proto.c |  92 ++++++++++++++++++++++
>  include/linux/mfd/cros_ec.h             |  18 +++++
>  include/linux/mfd/cros_ec_commands.h    |  34 ++++++++
>  5 files changed, 230 insertions(+), 107 deletions(-)

Set does not apply on v4.8-rc1.

Please rebase and resend with all the collected Acks applied.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog