linux-kernel - Re: [PATCH v4] mfd: dm355evm_msp: Refactoring for add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 8 Aug 2016 13:36:44 +0200
From:	SF Markus Elfring <elfring@...rs.sourceforge.net>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH v4] mfd: dm355evm_msp: Refactoring for add_child()

>> v4: Further feedback was integrated into this message.
> 
> This is not a good change-log.  What actually changed?

Which kind of information would you find more useful in this case?


>> @@ -222,19 +222,20 @@ static struct device *add_child(struct i2c_client *client, const char *name,
>>  		status = platform_device_add_resources(pdev, &r, 1);
>>  		if (status < 0) {
>>  			dev_dbg(&pdev->dev, "can't add irq\n");
>> -			goto err;
>> +			goto put_device;
>>  		}
>>  	}
>>  
>>  	status = platform_device_add(pdev);
>> +	if (status)
>> +		goto put_device;
>>  
>> -err:
>> -	if (status < 0) {
>> -		platform_device_put(pdev);
>> -		dev_err(&client->dev, "can't add %s dev\n", name);
>> -		return ERR_PTR(status);
>> -	}
>>  	return &pdev->dev;
>> +
>> +put_device:
>> +	platform_device_put(pdev);
>> +	dev_err(&client->dev, "failed to add device %s\n", name);
> 
> ... and remove this line.

Do you really want that this error message should be deleted?

How does this response fit to your request to introduce such a message
for the function "add_numbered_child" (on 2016-06-08)?
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1162299.html
https://lkml.org/lkml/2016/6/8/467

Regards,
Markus