linux-kernel - Re: [PACTH v2] mmc: sdhci: Do not allow tuning procedure to be interrupted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 8 Aug 2016 09:16:59 -0700
From:	Benson Leung <bleung@...omium.org>
To:	robert.foss@...labora.com
Cc:	adrian.hunter@...el.com, ulf.hansson@...aro.org,
	linux-mmc@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Andrew Bresticker <abrestic@...omium.org>,
	Kevin Cernekee <cernekee@...omium.org>,
	Christopher Freeman <cfreeman@...dia.com>
Subject: Re: [PACTH v2] mmc: sdhci: Do not allow tuning procedure to be interrupted

On Mon, Aug 8, 2016 at 9:11 AM, <robert.foss@...labora.com> wrote:
>
> From: Christopher Freeman <cfreeman@...dia.com>
>
> wait_event_interruptible_timeout() will return early if the blocked
> process receives a signal, causing the driver to abort the tuning
> procedure and possibly leaving the controller in a bad state.  Since the
> tuning command is expected to complete quickly (<50ms) and we've set a
> timeout, use wait_event_timeout() instead.
>
> Signed-off-by: Christopher Freeman <cfreeman@...dia.com>
> Tested-by: Robert Foss <robert.foss@...labora.com>
> Signed-off-by: Robert Foss <robert.foss@...labora.com>

Reviewed-by: Benson Leung <bleung@...omium.org>

Thanks Robert!



-- 
Benson Leung
Senior Software Engineer, Chrom* OS
bleung@...omium.org