linux-kernel - Re: [PATCH v2] x86/hweight: fix open-coded versions of 32bit and 64bit hweight calculations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 9 Aug 2016 00:34:06 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Jiri Kosina <jikos@...nel.org>
Cc:	kbuild-all@...org, Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	x86@...nel.org, linux-kernel@...r.kernel.org,
	Mike Galbraith <umgwanakikbuti@...il.com>,
	Borislav Petkov <bp@...e.de>
Subject: Re: [PATCH v2] x86/hweight: fix open-coded versions of 32bit and
 64bit hweight calculations

Hi Jiri,

[auto build test ERROR on tip/auto-latest]
[also build test ERROR on v4.8-rc1 next-20160808]
[cannot apply to tip/x86/core]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Jiri-Kosina/x86-hweight-fix-open-coded-versions-of-32bit-and-64bit-hweight-calculations/20160809-001505
config: i386-tinyconfig (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

>> arch/x86/lib/hweight.S:63:2: error: #else without #if
    #else /* CONFIG_X86_32 */
     ^~~~
>> arch/x86/lib/hweight.S:75:2: error: #endif without #if
    #endif
     ^~~~~

vim +63 arch/x86/lib/hweight.S

f5967101 Borislav Petkov 2016-05-30  57  	movabsq $0x0101010101010101, %rdx
4792d6cc Jiri Kosina     2016-08-08  58  	imulq   %rdx, %rax
4792d6cc Jiri Kosina     2016-08-08  59  	shrq    $56, %rax
f5967101 Borislav Petkov 2016-05-30  60  
f5967101 Borislav Petkov 2016-05-30  61  	popq    %rdx
f5967101 Borislav Petkov 2016-05-30  62  	ret
f5967101 Borislav Petkov 2016-05-30 @63  #else /* CONFIG_X86_32 */
f5967101 Borislav Petkov 2016-05-30  64  	/* We're getting an u64 arg in (%eax,%edx): unsigned long hweight64(__u64 w) */
f5967101 Borislav Petkov 2016-05-30  65  	pushl   %ecx
f5967101 Borislav Petkov 2016-05-30  66  
f5967101 Borislav Petkov 2016-05-30  67  	call    __sw_hweight32
f5967101 Borislav Petkov 2016-05-30  68  	movl    %eax, %ecx                      # stash away result
f5967101 Borislav Petkov 2016-05-30  69  	movl    %edx, %eax                      # second part of input
f5967101 Borislav Petkov 2016-05-30  70  	call    __sw_hweight32
f5967101 Borislav Petkov 2016-05-30  71  	addl    %ecx, %eax                      # result
f5967101 Borislav Petkov 2016-05-30  72  
f5967101 Borislav Petkov 2016-05-30  73  	popl    %ecx
f5967101 Borislav Petkov 2016-05-30  74  	ret
f5967101 Borislav Petkov 2016-05-30 @75  #endif
f5967101 Borislav Petkov 2016-05-30  76  ENDPROC(__sw_hweight64)

:::::: The code at line 63 was first introduced by commit
:::::: f5967101e9de12addcda4510dfbac66d7c5779c3 x86/hweight: Get rid of the special calling convention

:::::: TO: Borislav Petkov <bp@...e.de>
:::::: CC: Ingo Molnar <mingo@...nel.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (6290 bytes)