linux-kernel - Re: [PATCH] Revert "of/irq: Mark initialised interrupt controllers as populated"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 8 Aug 2016 12:02:43 -0500
From:	Rob Herring <robh@...nel.org>
To:	Philipp Zabel <p.zabel@...gutronix.de>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel@...gutronix.de" <kernel@...gutronix.de>,
	Jon Hunter <jonathanh@...dia.com>
Subject: Re: [PATCH] Revert "of/irq: Mark initialised interrupt controllers as populated"

On Mon, Aug 8, 2016 at 11:47 AM, Philipp Zabel <p.zabel@...gutronix.de> wrote:
> This reverts commit 15cc2ed6dcf91a8658e084be4e140147161819d7 ("of/irq:
> Mark initialised interrupt controllers as populated"), which breaks the
> i.MX6 GPC (General Power Controller). The GPC is both an interrupt
> controller and a power domain controller. If the interrupt code sets the
> OF_POPULATED bit early, the power domain driver is silently skipped, as
> are the GPU and VPU drivers that are missing their power domain.

What makes the GPC need to be handled early as an interrupt
controller? Looks like the timer is not dependent on it, so maybe it
can be converted to a regular driver?

A simple alternative here would be to set the OF_POPULATED before the
callback function is called, so your GPC callback can clear it.

Rob

>
> Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de>
> Cc: Jon Hunter <jonathanh@...dia.com>
> Cc: Rob Herring <robh@...nel.org>
> ---
>  drivers/of/irq.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/of/irq.c b/drivers/of/irq.c
> index 89a71c6..7d3f93f 100644
> --- a/drivers/of/irq.c
> +++ b/drivers/of/irq.c
> @@ -559,8 +559,6 @@ void __init of_irq_init(const struct of_device_id *matches)
>                          * its children can get processed in a subsequent pass.
>                          */
>                         list_add_tail(&desc->list, &intc_parent_list);
> -
> -                       of_node_set_flag(desc->dev, OF_POPULATED);
>                 }
>
>                 /* Get the next pending parent that might have children */
> --
> 2.8.1
>