linux-kernel - Re: [PATCH] staging: ion: remove __GFP_NOWARN when use low order gfp flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 8 Aug 2016 11:44:09 -0700
From:	Laura Abbott <labbott@...hat.com>
To:	Chen Feng <puck.chen@...ilicon.com>, sumit.semwal@...aro.org,
	gregkh@...uxfoundation.org, arve@...roid.com,
	riandrews@...roid.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Cc:	suzhuangluan@...ilicon.com, dan.zhao@...ilicon.com,
	oliver.fu@...ilicon.com, qijiwen@...ilicon.com,
	saberlily.xia@...ilicon.com, xuyiping@...ilicon.com,
	puck.chen@...mail.com
Subject: Re: [PATCH] staging: ion: remove __GFP_NOWARN when use low order gfp
 flags

On 07/29/2016 07:09 PM, Chen Feng wrote:
> It's useful to show the current memory in detail when alloc failed.
>
> And, there may be a lot of high order alloc failed, just show memory
> when an order 0 alloc failed.
>
> Signed-off-by: Chen Feng <puck.chen@...ilicon.com>
> ---
>  drivers/staging/android/ion/ion_system_heap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/staging/android/ion/ion_system_heap.c
> index b69dfc7..c3b7975 100644
> --- a/drivers/staging/android/ion/ion_system_heap.c
> +++ b/drivers/staging/android/ion/ion_system_heap.c
> @@ -28,7 +28,7 @@
>
>  static gfp_t high_order_gfp_flags = (GFP_HIGHUSER | __GFP_ZERO | __GFP_NOWARN |
>  				     __GFP_NORETRY) & ~__GFP_RECLAIM;
> -static gfp_t low_order_gfp_flags  = (GFP_HIGHUSER | __GFP_ZERO | __GFP_NOWARN);
> +static gfp_t low_order_gfp_flags  = (GFP_HIGHUSER | __GFP_ZERO);
>  static const unsigned int orders[] = {8, 4, 0};
>  static const int num_orders = ARRAY_SIZE(orders);
>  static int order_to_index(unsigned int order)
>

Acked-by: Laura Abbott <labbott@...hat.com>