linux-kernel - RE: [PATCH] ACPICA: Remove unnecessary '\n' in the end of ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 8 Aug 2016 21:38:41 +0000
From:	"Moore, Robert" <robert.moore@...el.com>
To:	"Zheng, Lv" <lv.zheng@...el.com>,
	Alexander Kuleshov <kuleshovmail@...il.com>
CC:	"Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
	Len Brown <lenb@...nel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"devel@...ica.org" <devel@...ica.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] ACPICA: Remove unnecessary '\n' in the end of ACPI_INFO
 output

I put that \n in there to break up the output from AcpiExec. This comes up every year or so, I think I'll give up -- without really seeing the harm in an extra \n.



> -----Original Message-----
> From: Zheng, Lv
> Sent: Sunday, August 7, 2016 5:56 PM
> To: Alexander Kuleshov <kuleshovmail@...il.com>; Moore, Robert
> <robert.moore@...el.com>
> Cc: Wysocki, Rafael J <rafael.j.wysocki@...el.com>; Len Brown
> <lenb@...nel.org>; linux-acpi@...r.kernel.org; devel@...ica.org; linux-
> kernel@...r.kernel.org
> Subject: RE: [PATCH] ACPICA: Remove unnecessary '\n' in the end of
> ACPI_INFO output
> 
> > From: Alexander Kuleshov [mailto:kuleshovmail@...il.com]
> > Subject: [PATCH] ACPICA: Remove unnecessary '\n' in the end of
> > ACPI_INFO output
> >
> > as the ACPI_INFO already prints `\n` in the end itself.
> [Lv Zheng]
> Looks good.
> Acked-by: Lv Zheng <lv.zheng@...el.com>
> However this patch should go through ACPICA upstream.
> 
> Thanks
> -Lv
> 
> >
> > Signed-off-by: Alexander Kuleshov <kuleshovmail@...il.com>
> > ---
> >  drivers/acpi/acpica/tbxfload.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/acpica/tbxfload.c
> > b/drivers/acpi/acpica/tbxfload.c index ac71abc..e7119b7 100644
> > --- a/drivers/acpi/acpica/tbxfload.c
> > +++ b/drivers/acpi/acpica/tbxfload.c
> > @@ -240,7 +240,7 @@ acpi_status acpi_tb_load_namespace(void)
> >  	}
> >
> >  	if (!tables_failed) {
> > -		ACPI_INFO(("%u ACPI AML tables successfully acquired and
> > loaded\n", tables_loaded));
> > +		ACPI_INFO(("%u ACPI AML tables successfully acquired and
> > loaded", tables_loaded));
> >  	} else {
> >  		ACPI_ERROR((AE_INFO,
> >  			    "%u table load failures, %u successful",
> > --
> > 2.8.0.rc3.1353.gea9bdc0