linux-kernel - Re: [alsa-devel] [PATCH 1/4] ASoC: da7213: Default to 64 BCLKs per WCLK to support all formats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 8 Aug 2016 09:52:43 +0200 (CEST)
From:	Peter Meerwald-Stadler <pmeerw@...erw.net>
To:	Adam Thomson <Adam.Thomson.Opensource@...semi.com>
cc:	Mark Brown <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
	Support Opensource <support.opensource@...semi.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH 1/4] ASoC: da7213: Default to 64 BCLKs per
 WCLK to support all formats


> Previously code defaulted to 32 BCLKS per WCLK which meant 24 and
> 32 bit DAI formats would not work properly. This patch fixes the
> issue by defaulting to 64 BCLKs per WCLK.

Tested-by: Peter Meerwald-Stadler <pmeerw@...erw.net>
 
> Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@...semi.com>
> ---
>  sound/soc/codecs/da7213.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c
> index e5527bc..bcf1834 100644
> --- a/sound/soc/codecs/da7213.c
> +++ b/sound/soc/codecs/da7213.c
> @@ -1247,8 +1247,8 @@ static int da7213_set_dai_fmt(struct snd_soc_dai *codec_dai, unsigned int fmt)
>  		return -EINVAL;
>  	}
>  
> -	/* By default only 32 BCLK per WCLK is supported */
> -	dai_clk_mode |= DA7213_DAI_BCLKS_PER_WCLK_32;
> +	/* By default only 64 BCLK per WCLK is supported */
> +	dai_clk_mode |= DA7213_DAI_BCLKS_PER_WCLK_64;
>  
>  	snd_soc_write(codec, DA7213_DAI_CLK_MODE, dai_clk_mode);
>  	snd_soc_update_bits(codec, DA7213_DAI_CTRL, DA7213_DAI_FORMAT_MASK,
> 

-- 

Peter Meerwald-Stadler
+43-664-2444418 (mobile)