linux-kernel - Re: [PATCH 3/3] mpt3sas: Fix warnings exposed by W=1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 08 Aug 2016 21:16:10 -0400
From:	"Martin K. Petersen" <martin.petersen@...cle.com>
To:	Calvin Owens <calvinowens@...com>
Cc:	Sathya Prakash <sathya.prakash@...adcom.com>,
	Chaitra P B <chaitra.basappa@...adcom.com>,
	Suganath Prabu Subramani 
	<suganath-prabu.subramani@...adcom.com>,
	"James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	<MPT-FusionLinux.pdl@...adcom.com>, <linux-scsi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <kernel-team@...com>
Subject: Re: [PATCH 3/3] mpt3sas: Fix warnings exposed by W=1

>>>>> "Calvin" == Calvin Owens <calvinowens@...com> writes:

Calvin> Trivial non-functional changes for a couple annoying things: 1)
Calvin> Functions local to files are not declared static, which is
Calvin> frustrating when reading the code because it's non-obvious at
Calvin> first glance what's actually called from other files.

Calvin>   2) Set-but-unused variables abound, presumably to mask
Calvin> -Wunused-result errors in the past. None of these are flagged
Calvin> today though (with one exception noted below), so remove them.

Calvin> Fixing (2) exposed the fact that we improperly ignore the return
Calvin> value of scsi_device_reprobe() in _scsih_reprobe_lun(). Fixing
Calvin> the calling code to deal with the potential error is
Calvin> non-trivial, so for now just WARN().

Applied to 4.9/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering