linux-kernel - Re: [PATCH 1/3] ASoC: sst-haswell-pcm: don't use snd_soc_pcm_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 9 Aug 2016 03:26:57 +0000
From:	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:	Mark Brown <broonie@...nel.org>
CC:	Linux-ALSA <alsa-devel@...a-project.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Simon <horms@...ge.net.au>, <linux-renesas-soc@...r.kernel.org>,
	Jie Yang <yang.jie@...ux.intel.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] ASoC: sst-haswell-pcm: don't use snd_soc_pcm_set_drvdata()


Hi Mark

> > snd_soc_pcm_set_drvdata() will set driver data to rtd->dev,
> > but driver data of rtd->dev is already used as "rtd" on
> > soc_post_component_init().
> 
> This doesn't apply against current code, please check and resend.

Thanks.
It seems current your branch already has same patch.
Thus, This [1/3] is not needed now.

commit c999675b04c146aa57f6e853a3746de979427fad
Author: Ben Zhang <benzh@...omium.org>
Date:   Thu Jul 7 18:54:56 2016 -0700

    ASoC: Intel: Fix conflicting pcm dev drvdata on haswell
    
    soc-core sets the snd_soc_pcm_runtime->dev drvdata to
    snd_soc_pcm_runtime in soc_post_component_init, and access
    it in places like codec_reg_show.
    
    hsw_pcm_open overwrites the drvdata to point to hsw_pcm_data,
    confusing soc-core, and causing crashes when cat
    /sys/devices/pci0000:00/INT3438:00/.../System PCM/codec_reg
    
    This patch removes the set in hsw_pcm_open since it's no longer
    used. commit 7ff9d6714a5c ("ASoC: Intel: Split hsw_pcm_data for
    playback and capture") already removed all calls to
    snd_soc_pcm_get_drvdata(rtd).
    
    Signed-off-by: Ben Zhang <benzh@...omium.org>
    Signed-off-by: Mark Brown <broonie@...nel.org>