linux-kernel - dmatest no longer works on ARC SDP with DW DMAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Aug 2016 11:06:50 +0000
From:	Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>
To:	"dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>
CC:	"vinod.koul@...el.com" <vinod.koul@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Vlad Zakharov <Vladislav.Zakharov@...opsys.com>,
	"linux-snps-arc@...ts.infradead.org" 
	<linux-snps-arc@...ts.infradead.org>,
	Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>,
	Alexey Brodkin <Alexey.Brodkin@...opsys.com>,
	Nelson Pereira <Nelson.Pereira@...opsys.com>,
	"viresh.kumar@...aro.org" <viresh.kumar@...aro.org>,
	"andriy.shevchenko@...ux.intel.com" 
	<andriy.shevchenko@...ux.intel.com>
Subject: dmatest no longer works on ARC SDP with DW DMAC

dmatest on ARC SDP with DW DMAC became broken after df5c7386
("dmaengine: dw: some Intel devices has no memcpy support") and
30cb2639 ("dmaengine: dw: don't override platform data with autocfg")
commits.
* After df5c7386 commit "DMA_MEMCPY" capability option doesn't
get set correctly in platform driver version.
* After 30cb2639 commit
"data_width" and "nollp" parameters don't get set correctly in platform
driver version.

This happens because in old driver version there are three sources 
of parameters: pdata, device tree and autoconfig hardware registers. 
Some parameters were read from pdata and others from autoconfig
hardware registers. If pdata was absent some pdata structure 
fields were filled with parameters from device tree. But 30cb2639
commit disabled overriding pdata with autocfg, so if we use platform
driver version without pdata some parameters will not be set.

I'm wondering what would be the best way to fix this situation?
Should we strictly read parameters from only one source (pdata/device
tree/autoconfig) or we may mix some of them (for example getting
missing data from autoconf regs)?