linux-kernel - Re: [PATCH 1/4] media: pci: netup_unidvb: don't print error when adding adapter fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Aug 2016 10:41:05 -0400
From:	Abylay Ospan <aospan@...up.ru>
To:	Wolfram Sang <wsa@...-dreams.de>
Cc:	Wolfram Sang <wsa-dev@...g-engineering.com>,
	linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
	Sergey Kozlov <serjk@...up.ru>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	linux-media <linux-media@...r.kernel.org>
Subject: Re: [PATCH 1/4] media: pci: netup_unidvb: don't print error when
 adding adapter fails

yes, you right. If we remove this message there is no big problem. But
if we do not remove this it's also ok, right ? What the big deal to
remove this type of messages (i'm just interested) ?


For me it's ok to remove:
Acked-by: Abylay Ospan <aospan@...up.ru>


2016-08-09 10:58 GMT-04:00 Wolfram Sang <wsa@...-dreams.de>:
>
>> Sometimes it better to show more message - especially in error conditions :)
>
> Sure, if they contain additional information.
>
>> btw, do you make sanity check for "duplicate" log messages ?
>
> I checked all error messages if they contain additional information.
>
>>             ret = i2c_add_adapter(&i2c->adap);
>>     -       if (ret) {
>>     -               dev_err(&ndev->pci_dev->dev,
>>     -                       "%s(): failed to add I2C adapter\n", __func__);
>>     +       if (ret)
>>                     return ret;
>>     -       }
>
> IMHO, this one doesn't. __func__ is not helpful to users. And the error
> messages in the core will make sure that a developer knows where to
> start looking.
>



-- 
Abylay Ospan,
NetUP Inc.
http://www.netup.tv