linux-kernel - Re: [PATCH] IB/hfi1: Add missing error code assignment before test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Aug 2016 16:10:58 +0000
From:	"Dalessandro, Dennis" <dennis.dalessandro@...el.com>
To:	"christophe.jaillet@...adoo.fr" <christophe.jaillet@...adoo.fr>,
	"hal.rosenstock@...il.com" <hal.rosenstock@...il.com>,
	"Marciniszyn, Mike" <mike.marciniszyn@...el.com>,
	"dledford@...hat.com" <dledford@...hat.com>,
	"Hefty, Sean" <sean.hefty@...el.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Dalessandro, Dennis" <dennis.dalessandro@...el.com>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] IB/hfi1: Add missing error code assignment before test

On Wed, 2016-08-10 at 07:34 +0200, Christophe JAILLET wrote:
> It is likely that checking the result of 'setup_ctxt' is expected
> here.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  drivers/infiniband/hw/hfi1/file_ops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/hfi1/file_ops.c
> b/drivers/infiniband/hw/hfi1/file_ops.c
> index 1ecbec192358..ed76be39b20b 100644
> --- a/drivers/infiniband/hw/hfi1/file_ops.c
> +++ b/drivers/infiniband/hw/hfi1/file_ops.c
> @@ -222,7 +222,7 @@ static long hfi1_file_ioctl(struct file *fp,
> unsigned int cmd,
>  		ret = assign_ctxt(fp, &uinfo);
>  		if (ret < 0)
>  			return ret;
> -		setup_ctxt(fp);
> +		ret = setup_ctxt(fp);
>  		if (ret)
>  			return ret;
>  		ret = user_init(fp);

Thanks for the patch.

Acked-by: Dennis Dalessandro <dennis.dalessandro@...el.com>