linux-kernel - Re: [PATCH] regulator: Add LTC3676 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Aug 2016 10:45:09 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Tim Harvey <tharvey@...eworks.com>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Jaffer Kapasi <jkapasi@...ear.com>
Subject: Re: [PATCH] regulator: Add LTC3676 support

On Wed, Aug 10, 2016 at 05:44:55PM -0700, Tim Harvey wrote:
> On Wed, Aug 10, 2016 at 4:41 AM, Mark Brown <broonie@...nel.org> wrote:

> >> +/* LDO1 always on fixed 0.8V-3.3V via scalar via R1/R2 feeback res */
> >> +static struct regulator_ops ltc3676_fixed_standby_regulator_ops = {
> >> +};

> > Remove this, it's pointless.

> as I'm using macro's to define the ops, removing this ends up breaking
> compilation:

> do you know of some macro foo to best handle this? Part of me wants to
> ditch the macro's and just simply declare the array of regulators
> directly as its much easier to read/follow.

Just don't use the macro for that regulator?

> >> +     if (!rdesc->r1 || !rdesc->r2)
> >> +             return;

> > This is a bug if we ever get here, we should be complaining loudly.

> This is now refactored due to using the core code for of parsing, but
> is it ok/standard to allow unused regulators to be not-defined in the
> dt and if so how do I handle that? Currently my test board uses 7 of
> the 8 regulators but the unused one is still registered with linux.

Substitute in versions of the ops that don't have any of the voltage
operations since without the dividers you can't support them, or make
the voltage operations return -EINVAL.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)