linux-kernel - Re: [PATCH 4/4] befs: remove unnecessary initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Aug 2016 12:07:23 +0100
From:	Luis de Bethencourt <luisbg@....samsung.com>
To:	Salah Triki <salah.triki@...il.com>, akpm@...ux-foundation.org,
	viro@...iv.linux.org.uk
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] befs: remove unnecessary initialization

On 10/08/16 23:12, Salah Triki wrote:
> There is no need to init block, since it will be overwitten later by
> iaddr2blockno().
> 
> Signed-off-by: Salah Triki <salah.triki@...il.com>
> ---
>  fs/befs/io.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/befs/io.c b/fs/befs/io.c
> index f9790f5..39d0dce 100644
> --- a/fs/befs/io.c
> +++ b/fs/befs/io.c
> @@ -27,7 +27,7 @@ struct buffer_head *
>  befs_bread_iaddr(struct super_block *sb, befs_inode_addr iaddr)
>  {
>  	struct buffer_head *bh;
> -	befs_blocknr_t block = 0;
> +	befs_blocknr_t block;
>  
>  	befs_debug(sb, "---> Enter %s "
>  		   "[%u, %hu, %hu]", __func__, iaddr.allocation_group,
> 

Applied and merged to:
https://github.com/luisbg/linux-befs/commits/for-next

Thanks Salah :)
Luis