linux-kernel - Re: [PATCH v5 2/2] mfd: dm355evm_msp: Change error messages in add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Aug 2016 14:39:35 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	SF Markus Elfring <elfring@...rs.sourceforge.net>
cc:	Lee Jones <lee.jones@...aro.org>, kernel-janitors@...r.kernel.org,
	wsa@...-dreams.de, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 2/2] mfd: dm355evm_msp: Change error messages in
 add_child()



On Thu, 11 Aug 2016, SF Markus Elfring wrote:

> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Thu, 11 Aug 2016 14:00:43 +0200
>
> Delete an error message at the end while increasing the importance of
> related information.
>
> Link: https://lkml.kernel.org/g/<20160809153615.GU5243@...l>
> Suggested-by: Lee Jones <lee.jones@...aro.org>
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>
> v5: Rebased on the source files from Linux next-20160809.
>
>     Requested changes were applied.
>
>  drivers/mfd/dm355evm_msp.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mfd/dm355evm_msp.c b/drivers/mfd/dm355evm_msp.c
> index 86eca61..463f9e2e 100644
> --- a/drivers/mfd/dm355evm_msp.c
> +++ b/drivers/mfd/dm355evm_msp.c
> @@ -208,7 +208,7 @@ static struct device *add_child(struct i2c_client *client, const char *name,
>  	if (pdata) {
>  		status = platform_device_add_data(pdev, pdata, pdata_len);
>  		if (status < 0) {
> -			dev_dbg(&pdev->dev, "can't add platform_data\n");
> +			dev_err(&pdev->dev, "can't add platform_data\n");

Isn't this message unnecessary?  platform_device_add_data only fails on
failure of kmemdup, which I assume ends up in kmalloc eventually and
prints a backtrace on failure.

The same is true of platform_device_add_resources below.

julia

>  			goto put_device;
>  		}
>  	}
> @@ -221,7 +221,7 @@ static struct device *add_child(struct i2c_client *client, const char *name,
>
>  		status = platform_device_add_resources(pdev, &r, 1);
>  		if (status < 0) {
> -			dev_dbg(&pdev->dev, "can't add irq\n");
> +			dev_err(&pdev->dev, "can't add irq\n");
>  			goto put_device;
>  		}
>  	}
> @@ -234,7 +234,6 @@ static struct device *add_child(struct i2c_client *client, const char *name,
>
>  put_device:
>  	platform_device_put(pdev);
> -	dev_err(&client->dev, "failed to add device %s\n", name);
>  	return ERR_PTR(status);
>  }
>
> --
> 2.9.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>