linux-kernel - Re: [PATCH v3 11/14] media: platform: pxa_camera: make a standalone v4l2 device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 14 Aug 2016 21:30:04 +0200
From:	Robert Jarzmik <robert.jarzmik@...e.fr>
To:	Hans Verkuil <hverkuil@...all.nl>
Cc:	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Guennadi Liakhovetski <g.liakhovetski@....de>,
	Jiri Kosina <trivial@...nel.org>, linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org
Subject: Re: [PATCH v3 11/14] media: platform: pxa_camera: make a standalone v4l2 device

Hans Verkuil <hverkuil@...all.nl> writes:

> On 08/08/2016 09:30 PM, Robert Jarzmik wrote:
>
>> +	pcdev->sensor = subdev;
>> +	pcdev->vdev.queue = &pcdev->vb2_vq;
>> +	pcdev->vdev.v4l2_dev = &pcdev->v4l2_dev;
>
> You're missing this line here:
>
> 	pcdev->vdev.ctrl_handler = subdev->ctrl_handler;
>
> This ensures that the sensor's controls are exposed to the video device node.
Okay, I'm on it, for v4.

>> +	video_set_drvdata(&pcdev->vdev, pcdev);
>> +
>> +	v4l2_disable_ioctl(vdev, VIDIOC_G_STD);
>> +	v4l2_disable_ioctl(vdev, VIDIOC_S_STD);
>
> Since you don't implement vidioc_g/s_std these two lines can be removed.
Okay, for v4.

Cheers.

-- 
Robert