linux-kernel - Re: [PATCH 0/4] Use complete() instead of complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160814225132.GH10501@katana>
Date:	Mon, 15 Aug 2016 00:51:32 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Daniel Wagner <wagi@...om.org>
Cc:	linux-kernel@...r.kernel.org, Alex Dubov <oakad@...oo.com>,
	Ashutosh Dixit <ashutosh.dixit@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Sudeep Dutt <sudeep.dutt@...el.com>,
	Daniel Wagner <daniel.wagner@...-carit.de>
Subject: Re: [PATCH 0/4]  Use complete() instead of complete_all()

On Fri, Aug 05, 2016 at 11:25:59AM +0200, Daniel Wagner wrote:
> From: Daniel Wagner <daniel.wagner@...-carit.de>
> 
> Hi,
> 
> Using complete_all() is not wrong per se but it suggest that there
> might be more than one reader. For -rt I am reviewing all
> complete_all() users and would like to leave only the real ones in the
> tree. The main problem for -rt about complete_all() is that it can be
> uses inside IRQ context and that can lead to unbounded amount work
> inside the interrupt handler. That is a no no for -rt.
> 
> The patches grouped per subsystem and in small batches to allow
> reviewing. Unfortanatly I am not so good in coming up with unique
> commit message, so please bear with me in that regard. I could also
> squash them together, although each patch containts a very short
> reasoning why there is only one waiter. Let me know what you rather
> prefer. One patch which updates all complete_all() users or those 4
> patches with some reasoning.
> 
> It is only test compiled because I don't have the all the hardware.

All applied to for-current, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)